Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: test voq/test_fabric_cli_and_db.py::test_fabric_cli_isolate_supervisor does not restore fabric port to initial status False #16067

Open
rawal01 opened this issue Dec 13, 2024 · 0 comments

Comments

@rawal01
Copy link
Contributor

rawal01 commented Dec 13, 2024

Issue Description

Run the test test voq/test_fabric_cli_and_db.py::test_fabric_cli_isolate_supervisor on t2 topo with voq chassis.
This was tested with t2 topo and Nokia chassis running 202405 based image.
I see that after the test completes it does not restore the port to its initial isolate state if initial state was False.
After analyzing the logs I found unisolate is never called the reason being 'originalIsolateStatus' is being overwritten after changing the fabric port isolate state incorrectly.

Results you see

I see after the test completes the the isolate state of fabric port is not false it is still true. See below output the manual isolate is true and port is still isolated
asic4
Local Link Auto Isolated Manual Isolated Isolated


       0                0                  0           0
       1                0                  0           0
       2                0                  0           0
       3                0                  1           1
       4                0                  0           0
       5                0                  0           0
       6                0                  0           0
       7                0                  0           0
      32                0                  0           0
      33                0                  0           0
      34                0                  0           0
      35                0                  0           0
      36                0                  0           0
      37                0                  0           0
      38                0                  0           0
      39                0                  1           1
      40                0                  0           0
      41                0                  0           0
      42                0                  0           0
      43                0                  0           0
      44                0                  0           0
      45                0                  0           0
      46                0                  1           1
      47                0                  0           0
      88                0                  0           0
      89                0                  0           0
      90                0                  0           0
      91                0                  0           0
      92                0                  1           1
      93                0                  0           0
      94                0                  0           0
      95                0                  1           1
     144                0                  0           0
     145                0                  1           1
     146                0                  1           1
     147                0                  1           1
     148                0                  0           0
     149                0                  0           0
     150                0                  0           0
     151                0                  0           0
     152                0                  0           0
     153                0                  1           1
     154                0                  1           1
     155                0                  0           0
     156                0                  0           0
     157                0                  0           0
     158                0                  0           0
     159                0                  0           0

From log the original state was False
DEBUG tests.common.devices.base:base.py:71 /data/tests/common/devices/multi_asic.py::_run_on_asics#135: [ixre-cpm-chassis19] AnsibleModule::shell, args=["sonic-db-cli -n asic4 CONFIG_DB hget 'FABRIC_PORT|Fabric32' isolateStatus"], kwargs={"module_ignore_errors": true}
DEBUG tests.common.devices.base:base.py:108 /data/tests/common/devices/multi_asic.py::_run_on_asics#135: [ixre-cpm-chassis19] AnsibleModule::shell Result => {"changed": true, "stdout": "False", "stderr": "", "rc": 0, "cmd": "sonic-db-cli -n asic4 CONFIG_DB hget 'FABRIC_PORT|Fabric32' isolateStatus", "start": "2024-12-12 23:07:24.491393", "end": "2024-12-12 23:07:24.511762", "delta": "0:00:00.020369", "msg": "", "invocation": {"module_args": {"_raw_params": "sonic-db-cli -n asic4 CONFIG_DB hget 'FABRIC_PORT|Fabric32' isolateStatus", "_uses_shell": true, "warn": false, "stdin_add_newline": true, "strip_empty_ends": true, "argv": null, "chdir": null, "executable": null, "creates": null, "removes": null, "stdin": null}}, "stdout_lines": ["False"], "stderr_lines": [], "_ansible_no_log": null, "failed": false}
DEBUG tests.voq.test_fabric_cli_and_db:test_fabric_cli_and_db.py:214 originalIsolateStatus: False

Results you expected to see

The test should rever fabric port from isolate to unisolate if original state was unisolated

Is it platform specific

generic

Relevant log output

No response

Output of show version

No response

Attach files (if any)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant