Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py version pinning not reflected in install instructions #13

Open
smangham opened this issue Jul 16, 2024 · 0 comments
Open

setup.py version pinning not reflected in install instructions #13

smangham opened this issue Jul 16, 2024 · 0 comments

Comments

@smangham
Copy link

smangham commented Jul 16, 2024

setup.py contains the following dynamically-generated requirement:

[...]

if minor < 7:
    cp = str(30+minor)
else:
    cp = '38'

if dist_name == 'ubuntu':
   dist_ver = int(dist_ver.split('.')[0])
if dist_ver >= 14:
    dist =  'ubuntu-14.04'
if dist_ver >= 16:
    dist = 'ubuntu-16.04'
if dist_ver >= 18:
    dist = 'ubuntu-18.04'
if dist_ver >= 20:
    dist = 'ubuntu-20.04'
[....]

wxpython_url = 'wxPython @ https://extras.wxpython.org/wxPython4/extras/linux/gtk3/'+dist+'/wxPython-4.1.0-cp'+cp+'-cp'+cp+'-linux_x86_64.whl'

This forces Python 3.8 and wxPython 4.1.0. As a result, it's not possible to install with Python 3.10. Even on 3.8, the section in the install guide:

python3 -m pip install -U -f https://extras.wxpython.org/wxPython4/extras/linux/gtk3/ubuntu-22.04 wxPython

Is also wrong, as it still installs 4.2.1, which is incompatible. The Python and wxPython version pins should be made explicit in the setup.py.

Whilst it forces the ubuntu-20.04 version of wxPython, this also seems to work on Ubuntu 22.04 - but that pin should ideally be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant