Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 추천 모임 목록 조회 구현 #523

Merged
merged 7 commits into from
Jan 7, 2025
Merged

feat: 추천 모임 목록 조회 구현 #523

merged 7 commits into from
Jan 7, 2025

Conversation

mikekks
Copy link
Member

@mikekks mikekks commented Jan 6, 2025 •
edited
Loading

👩‍💻 Contents

  • 추천 모임 목록 조회하는 기능을 구현했습니다.
  • 기능 명세서에 default 는 '현재 모집중인 모임'을 반환해야해서 querydsl 동적쿼리를 사용했습니다.

param 없는 경우

스크린샷 2025-01-07 오전 12 54 18

param 있는 경우

스크린샷 2025-01-07 오전 12 55 36

📝 Review Note

📣 Related Issue

✅ 점검사항

  • docker-compose.yml 파일에 마이그레이션 한 API의 포워딩을 변경해줬나요?
  • Spring Secret 값을 수정하거나 추가했다면 Github Secret에서 수정을 해줬나요?
  • Nestjs Secret 값을 수정하거나 추가했다면 Docker-Compose.yml 파일 및 인스턴스 내부의 .env 파일을 수정했나요?

@mikekks mikekks added the 🎁 feature 새로운 기능 label Jan 6, 2025
@mikekks mikekks requested a review from hoonyworld January 6, 2025 15:49
@mikekks mikekks self-assigned this Jan 6, 2025
@height Height
Copy link

height bot commented Jan 6, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

hoonyworld
hoonyworld reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@hoonyworld hoonyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 민규님!

몇가지 코멘트 남겨놓았습니다

main/src/main/java/org/sopt/makers/crew/main/entity/meeting/MeetingSearchRepositoryImpl.java Outdated Show resolved Hide resolved
...rc/main/java/org/sopt/makers/crew/main/meeting/v2/dto/response/MeetingV2GetRecommendDto.java Outdated Show resolved Hide resolved
@mikekks mikekks requested a review from hoonyworld January 7, 2025 04:26
hoonyworld
hoonyworld approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@hoonyworld hoonyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@mikekks mikekks merged commit 53adbbe into develop Jan 7, 2025
1 check passed
@mikekks mikekks deleted the feat/#521 branch January 7, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoonyworld hoonyworld hoonyworld approved these changes

Assignees

@mikekks mikekks

Labels
🎁 feature 새로운 기능 size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 홈 추천 모임 목록 조회
2 participants
@mikekks @hoonyworld