Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 쪽지 모달 > 쪽지 전송 실패 알림 추가 #762

Closed
wants to merge 1 commit into from

Conversation

NamJwong
Copy link
Member

@NamJwong NamJwong commented Jun 3, 2023

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

🤔 그렇다면, 어떻게 구현했어요~?

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

@NamJwong NamJwong added the ✨ Feature 신규 피쳐 label Jun 3, 2023
@NamJwong NamJwong requested a review from juno7803 June 3, 2023 08:26
@NamJwong NamJwong self-assigned this Jun 3, 2023
Copy link
Collaborator

@juno7803 juno7803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

Comment on lines +121 to +124
await Alert({
title: '쪽지 전송 실패',
content: '문제가 발생했습니다.',
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3; await 빼도 괜찮지 않을깡?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

급하게 복붙하느라 .. 뺄게요!

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

✨✨ 스토리북으로 확인하기 ✨✨

@NamJwong
Copy link
Member Author

NamJwong commented Jun 3, 2023

급한 이슈여서 작업했는데 안 급해져서 다시 생각해보면

에러 상황 === 쪽지 전송 실패는 아니어서 에러 분기 처리가 필요할 듯 ㅠ 일단 머지 보류할게요

그래도 지금 멘토링 때문에 쪽지 활발히 쓰이는 만큼 조만간 be친구들이랑 커뮤니케이션 해서 꼭 에러UI 처리해놓겠습니당

=> 현재 에러 분리 처리를 할 be 리소스가 없는데다 예상되는 위험이 생각보다 많이 낮아서 3기로 작업 미루기로 함 => PR 닫겠습니다

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

🚀 프리뷰 배포 확인하기 🚀

https://5c1c2299.sopt-internal-dev.pages.dev

@NamJwong NamJwong closed this Jun 4, 2023
@NamJwong NamJwong deleted the feat/#761 branch June 4, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 쪽지 전송 실패 시 실패 알림 모달 띄우기
2 participants