From 0c52d9c686057f910d5fe56c756d263a306487e0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=EC=B5=9C=EC=A3=BC=EC=9A=A9?=
<121484561+wuzoo@users.noreply.github.com>
Date: Sun, 8 Sep 2024 00:25:07 +0900
Subject: [PATCH] =?UTF-8?q?[Refactor]=20QA=20=EB=B0=98=EC=98=81=20(#421)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* chore: blank로 새로운 탭에서 링크 접속
* chore: 14 -> 16시 ?
* chore: behance link 추가
* feat: behance optional type 추가
* feat: behance property 유무에 따른 아이콘 렌더링
---
src/assets/icons/ic_behance.svg | 12 ++++++++
src/lib/api/mock/about.ts | 3 +-
src/lib/types/about.ts | 1 +
.../components/Member/Card/index.tsx | 28 +++++++++----------
.../components/Member/Section/index.tsx | 2 ++
.../RecruitPage/components/Schedule/index.tsx | 2 +-
6 files changed, 31 insertions(+), 17 deletions(-)
create mode 100644 src/assets/icons/ic_behance.svg
diff --git a/src/assets/icons/ic_behance.svg b/src/assets/icons/ic_behance.svg
new file mode 100644
index 00000000..236ecc68
--- /dev/null
+++ b/src/assets/icons/ic_behance.svg
@@ -0,0 +1,12 @@
+
diff --git a/src/lib/api/mock/about.ts b/src/lib/api/mock/about.ts
index d4c714d8..c89f9436 100644
--- a/src/lib/api/mock/about.ts
+++ b/src/lib/api/mock/about.ts
@@ -57,6 +57,7 @@ const getMemberInfo = async (): Promise => ({
description: '동아리, 그 이상의 가치',
imageSrc: '/images/members/1.png',
gmail: 'president@sopt.org',
+ linkedin: '건-정-4aa699303/?trk=public-profile-join-page',
},
{
id: 12,
@@ -66,7 +67,6 @@ const getMemberInfo = async (): Promise => ({
description: '빛나는 열정을 펼칠 수 있도록',
imageSrc: '/images/members/12.png',
gmail: 'v_president@sopt.org',
- github: 'sjk4618',
},
{
id: 2,
@@ -124,6 +124,7 @@ const getMemberInfo = async (): Promise => ({
description: '세상을 바꾸는 디자이너들',
imageSrc: '/images/members/7.png',
gmail: 'design@sopt.org',
+ behance: '208a08e8',
},
{
id: 8,
diff --git a/src/lib/types/about.ts b/src/lib/types/about.ts
index 438fa6df..5b1aee29 100644
--- a/src/lib/types/about.ts
+++ b/src/lib/types/about.ts
@@ -16,6 +16,7 @@ export interface MemberType {
gmail?: string;
linkedin?: string;
github?: string;
+ behance?: string;
}
export type PositionType =
diff --git a/src/views/AboutPage/components/Member/Card/index.tsx b/src/views/AboutPage/components/Member/Card/index.tsx
index 64f6ae36..0fa03527 100644
--- a/src/views/AboutPage/components/Member/Card/index.tsx
+++ b/src/views/AboutPage/components/Member/Card/index.tsx
@@ -1,20 +1,12 @@
+import { ReactComponent as IcBehance } from '@src/assets/icons/ic_behance.svg';
import { ReactComponent as IcGithub } from '@src/assets/icons/ic_github.svg';
import { ReactComponent as IcLinkedin } from '@src/assets/icons/ic_linkedin.svg';
import { ReactComponent as IcMail } from '@src/assets/icons/mail.svg';
import NullImage from '@src/assets/images/null_image.png';
-import { PositionType } from '@src/lib/types/about';
+import { MemberType } from '@src/lib/types/about';
import * as St from './style';
-type MeberCardProps = {
- name: string;
- position: PositionType;
- description?: string;
- currentProject: string;
- imageSrc?: string;
- gmail?: string;
- linkedin?: string;
- github?: string;
-};
+type MemberCardProps = Omit;
const MemberCard = ({
name,
@@ -25,7 +17,8 @@ const MemberCard = ({
gmail,
linkedin,
github,
-}: MeberCardProps) => {
+ behance,
+}: MemberCardProps) => {
return (
@@ -44,20 +37,25 @@ const MemberCard = ({
{description || '-'}
{gmail && (
-
+
)}
{linkedin && (
-
+
)}
{github && (
-
+
)}
+ {behance && (
+
+
+
+ )}
);
diff --git a/src/views/AboutPage/components/Member/Section/index.tsx b/src/views/AboutPage/components/Member/Section/index.tsx
index 41a9e625..6e0bc04a 100644
--- a/src/views/AboutPage/components/Member/Section/index.tsx
+++ b/src/views/AboutPage/components/Member/Section/index.tsx
@@ -41,6 +41,7 @@ const MemberSection = ({ generation, members }: MemberSectionProps) => {
gmail,
linkedin,
github,
+ behance,
}) => (
{
gmail={gmail}
linkedin={linkedin}
github={github}
+ behance={behance}
/>
),
)}
diff --git a/src/views/RecruitPage/components/Schedule/index.tsx b/src/views/RecruitPage/components/Schedule/index.tsx
index 97d34113..53f8d163 100644
--- a/src/views/RecruitPage/components/Schedule/index.tsx
+++ b/src/views/RecruitPage/components/Schedule/index.tsx
@@ -15,7 +15,7 @@ const Schedule = () => {
YB 서류 결과 발표
- 9월 19일 14시
+ 9월 19일 16시
YB 면접
9월 21일 - 9월 22일