-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 메인페이지 업데이트 + OG 이미지 변경 #408
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생 많으셨습니다 ~ :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
옙브네용
수고많으셨습니다 ~~ 🚀 🚀
src/views/MainPage/index.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 이렇게 구현하면 YB 모집 딱! 시작할때 시간 맞춰서 배포해야돼서 불편할 것 같아요
분명 제가 예전에 valid 시간인지 체크하도록 구현해놨는데 누가 없앳어? 하고 찾아보니... 저네요... ^^
다른 작업하다가 갑자기 얘를 지워버렸네요.. (아마 뭐 테스트해보고 싶었거나 35기엔 이 배너가 재활용되지 않을거라고 생각했던 것 같아요)
요 코드 다시 살려두면 좋을 것 같아요
미리 배포해둘 수 있게!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 ! checkIsTimeInRage
로 지원 기간인지 확인하여 해당 반환값인 isValid
로 TopBanner
조건부 렌더링 하라는 말씀이신거죵 ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네넹 맞아요 그 모집 시간 이후부터만 배너 뜰 수 있게!
지금 상태로 배포하면 모집 기간과 무관하게 계속 탑 배너가 뜰테니까유 !
animation: ${BackgroundMove} 3s linear 0s infinite alternate; | ||
background: linear-gradient(274deg, #3c92ff 10%, #8fc0ff 74.12%, #3c92ff 100%); | ||
|
||
animation: ${BackgroundMove} 3s linear infinite; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 넵 ! 사실 저도 언석, 승히님이 따로 말씀이 없으셔서 일단은 후순위로 나중에 구현하는 걸로 생각했던 것 같아요
추후에 작업하겠습니다 !
뽕쌈하네요~~~ 🚀🚀 |
쌈@뽕하네요~~~🚀🚀 |
Summary
close #405
Screenshot
2024-09-05.12.32.09.mov
Comment