Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors no longer obeyed in 1.4.0 #41

Open
DannyBen opened this issue Jul 7, 2022 · 4 comments
Open

Colors no longer obeyed in 1.4.0 #41

DannyBen opened this issue Jul 7, 2022 · 4 comments
Labels
bug Something isn't working hterm-fallout Problems caused by removing hterm

Comments

@DannyBen
Copy link

DannyBen commented Jul 7, 2022

It seems that the color preferences are no longer respected in 1.4.0.
I was looking through the release notes, and did not see anything to explain it.

What version of GoTTY are you using (gotty --version)?

Gotty 1.4.0 - bug exists
Gotty 1.3.0 - bug does not exist

What operating system and browser are you using?

Ubuntu 20.04

What did you do?

Have this file in ~/.gotty

port = 3000

term = "hterm" 

preferences {
  background_color = "white"
  foreground_color = "black"
  cursor_color = "blue"
}

and run gotty --once ls

Note: This exact same config worked in all previous Gotty versions, including 1.3.0

What did you expect to see?

The terminal background color should be white.

What did you see instead?

The terminal background color was black.

@DannyBen
Copy link
Author

DannyBen commented Jul 8, 2022

I see now that hterm was removed - does this mean that there is no longer color customization?

@sorenisanerd sorenisanerd added bug Something isn't working hterm-fallout Problems caused by removing hterm labels Aug 28, 2022
@sorenisanerd
Copy link
Owner

Yes, unfortunately, that's the current state of affairs. I'm going to try to add some options in the UI to change colors, fonts, etc.

@DannyBen
Copy link
Author

DannyBen commented Sep 1, 2022

Yes, unfortunately, that's the current state of affairs. I'm going to try to add some options in the UI to change colors, fonts, etc.

I was afraid of that.... that is a deal breaker for me. Thanks for trying.

@sorenisanerd
Copy link
Owner

I'll also add an option to set the default theme once I get that far. That should let you do what you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hterm-fallout Problems caused by removing hterm
Projects
None yet
Development

No branches or pull requests

2 participants