Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard option to enable/disable keyboard navigation and ESC to end tour #70

Closed
sorich87 opened this issue Mar 23, 2013 · 5 comments

Comments

@sorich87
Copy link
Owner

No description provided.

@ghost ghost assigned LostCrew Mar 25, 2013
@LostCrew
Copy link
Contributor

@sorich87 sorry but i don't understand. can you explain me?

@sorich87
Copy link
Owner Author

I meant we should make the tour end when the user press escape key and add an option called 'keyboard' (true by default) to disable all the keyboard bindings (like the keyboard option of Bootstrap Modal).

@LostCrew
Copy link
Contributor

we already have a keyboard option. i only add the event handler attached to ESC key if keyboard is true.

@dstapp
Copy link

dstapp commented Nov 28, 2017

In the current version 0.12.0 with keyboard: true, closing the tour with ESC seems not to work. Was this ever implemented?

@vanderlee
Copy link

See PR #656.
It was easy enough to fix in JS, but this project uses coffeescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants