Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onShown not firing #735

Open
maxmann74 opened this issue Mar 20, 2020 · 1 comment
Open

onShown not firing #735

maxmann74 opened this issue Mar 20, 2020 · 1 comment

Comments

@maxmann74
Copy link

I am unable to get onShown event to fire. These events work fine: onShow, onNext, onPrev.

Has anyone else seen this issue? There are things I need to check for when each step is shown (to manipulate elements etc).

Thanks

@maxmann74
Copy link
Author

maxmann74 commented Mar 23, 2020

FYI:

I was able to figure this out. This line in bootstrap.tour.standalone.js throws an error for me:
offsetBottom = $(document).outerHeight() - tipOffset.top - $tip.outerHeight();

$(document).outerHeight() shows "not available" in chrome debug tools. I changed this to $(document).height(). Everything seems to work, it no longer errors, and the onShown event now fires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant