[cleaner] sos clean -vvv does not write to sos log files

[pmoravec]

Running sos clean on an existing sosreport, it never writes - even debug logs - to either log file. sos_logs/ui.log and sos_logs/sos.log are not touched. That differs from running sos report --clean with either verbosity mode.

On one side, sos clean should just clean the given sosreport and not alter it otherwise. On the other side, it should log somewhere its activity, and those files are the most applicable ones.

Some objections to enhancing sos clean by logging to the files?

[TrevorBenson]

Some objections to enhancing sos clean by logging to the files?

For what it's worth there are no objects from me. As both files have timestamps any new log entries should be easily distinguishable they were not inline cleanings.

A unique line could be also appended when called on existing reports, before the rest of the cleaner log entries. This might make it more apparent it was not inline for automated processes that would have only a minor delay between report creation and cleaning operations.

[TurboTurtle]

The original thought was that if it was cleaned after the fact, then we should not modify the existing log files. I still think that holds true, however there is definitely a net gain by having clean logs on hand in case a reviewing engineer thinks something went sideways with the obfuscation.

What if we add a new sos_logs/cleaner.log into the archive for any clean-after-the-fact? That way we're not modifying existing contents and we still get a record of what happened.

[pmoravec]

What if we add a new sos_logs/cleaner.log into the archive for any clean-after-the-fact? That way we're not modifying existing contents and we still get a record of what happened.

This makes sense. I am adding this to my todo list (but if somebody is willing to implement it, let me ping - I dont know when I can get to it).