Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor [global_]|options within component(s) and their inheritance among components #3906

Open
pmoravec opened this issue Jan 16, 2025 · 0 comments

Comments

@pmoravec
Copy link
Contributor

Splitting #3746 (comment) to a separate issue (that should be again dealt indepentently on upload feature). Current code - (without or in-near-future with) upload subcomponent - suffers by:

  • global options are "not so global" (e.g. neither apply to help, some dont apply to clean, many wont apply to upload). The idea of global options does not scale well with our current components. We shall revisit this approach.
  • currently, each component "enumeratively" declares each and every option it supports, namely those "shared among some other components". And passing lists of options among components is the same. It is error prone, lots of copy&pasted code. We should have one place with declaration "this component supports these options, can pass those to that component" - and a component will understand its options specification from that json/yaml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant