-
Notifications
You must be signed in to change notification settings - Fork 1
/
NOTES.change_PR13
44 lines (28 loc) · 1.34 KB
/
NOTES.change_PR13
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
Change description and rationale
--------------------------------
This PR improves the handling of missing ACE data and adds infrastructure to test various
missing data scenarios.
- Instead of dropping bad ACE data at the point of reading in values, leave the bad values
there (as indicated by a negative value) and do downstream handling of bad values.
- Indicate bad or N/A values with bold red text in the state table. If there is no average
P3 from MTA then use 0.0 for fluence prediction but show fluence as red.
- Plot bad ACE values so viewer can more easily see missing data. This shows up as a
vertical line to the bottom of the plot.
Code changes (list affected files and provide code diffs)
---------------------------------------------------------
See: https://github.com/sot/arc/pull/13/files
Testing
-------
Used unit tests to simulate various data loss scenarios and confirm
desired behavior. Ran code in the development environment for several
months and saw no unexpected outputs in run logs. Saw expected
improvements during periods of actual ACE data loss (see attached figure).
Interface impacts
-----------------
No change in interface.
Review
------
Community was notified about development version. No external code review.
Deployment plan
---------------
Will be deployed as soon as approved due to current ACE data loss event.