Add fid offset support to drift #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jeanconn
changed the title
taldcroft
reviewed
Oct 24, 2023
Co-authored-by: Tom Aldcroft <[email protected]>
taldcroft
approved these changes
Nov 11, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a function, get_fid_offset, to determine the expected y and z offsets of the fid lights from their positions, relative to the fid positions expected from the FEB07 fid characteristics (used in proseco and starcheck) and the current aimpoint drift model (which was last updated after the 2022:094 safe mode).
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
For functional testing, there is a new unit test and this notebook shows the use of the new offsets reduces the fid residuals on historical data.
https://cxc.cfa.harvard.edu/mta/ASPECT/ipynb/chandra_aca_fid_offset/check_fid_offset.html