Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docstring in drift.py #158

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Update docstring in drift.py #158

merged 2 commits into from
Oct 24, 2023

Conversation

taldcroft
Copy link
Member

Description

This fixes a misleading/confusing docstring for the ACA drift model, resolving ambiguity about arcsec vs. mm.

Interface impacts

None

Testing

Unit tests

  • No unit tests (docstring only)

Functional tests

No functional testing.

@taldcroft taldcroft requested a review from jeanconn October 24, 2023 16:53
jeanconn
jeanconn approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This should safe me some confusion next time I'm using this.

@taldcroft taldcroft merged commit 833e461 into master Oct 24, 2023
2 checks passed
@javierggt javierggt mentioned this pull request Nov 20, 2023
Closed
@javierggt javierggt mentioned this pull request Dec 5, 2023
Merged
@javierggt javierggt mentioned this pull request Feb 6, 2024
Merged
@javierggt javierggt deleted the taldcroft-patch-1 branch August 29, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldcroft @jeanconn