Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of starcheck evaluation of catalogs #15

Closed
6 tasks done
taldcroft opened this issue Jul 17, 2018 · 3 comments
Closed
6 tasks done

Review of starcheck evaluation of catalogs #15

taldcroft opened this issue Jul 17, 2018 · 3 comments

Comments

@taldcroft
Copy link
Member

taldcroft commented Jul 17, 2018

APR3018A

  • 20603: idx=11 is a 10.503 mag star that gets a 160" box despite 4 other 160s. Seems like smaller would be better. Looking at detailed report this looks odd and definitely needs more investigation. Fixed by Improved box size optimization strategy #32.

JUL0218A

  • No issues

JUN0418A

  • 49214: Fewer than 3 ACQ stars with 160 boxes ==> OK
  • 49211: WARNING: [10] Search Box Size. Star too faint for > 120 box => OK but I wonder why a smaller box isn't better here. Same 20433 in MAY0718A. OK

JUN1118A

JUN2318A

  • 21122: nice example of teeny box right on the edge.

MAY0718A

MAY1418A

  • 49252, 49247, 49242: significantly overlapping search boxes with basically identical mags. 50/50 that we get neither (swapped boxes)? There are no better stars, SAUSAGE went with 60" box on one and a hail mary 10.5 mag star. Review: proseco is doing the best possible here, and correctly assigns these stars with basically 50% on each.

MAY2118A

  • No new issues.
@jeanconn
Copy link
Contributor

Several catalogs have Angle Too Large warnings that suggest that the CCD boundaries should be confirmed if we want to push stuff out to the edge. I opened a new issue #17 for this as well, though I'm not sure about the best way to actually check the useful edges.

@jeanconn
Copy link
Contributor

jeanconn commented Jul 20, 2018

It's a known issue, but we should probably also track the

  • Fid light in search box

issue somewhere as something that will need to be double-checked on the Matlab side.

@taldcroft
Copy link
Member Author

Closing, will open a new one for final validation testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants