Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dark cal, agasc, and maybe agasc supplement version info in pickle #200

Open
taldcroft opened this issue Dec 17, 2018 · 6 comments

Comments

@taldcroft
Copy link
Member

This includes at least name of the dark cal file if taken from mica or the entire dark map if not.

Maybe do something similar for stars.

@jeanconn
Copy link
Contributor

Did you have this @taldcroft or did you want me to take it? I just wasn't sure I'd have something good by COB today.

@jeanconn
Copy link
Contributor

I'd also like "what version of proseco" in there somewhere.

@jeanconn
Copy link
Contributor

jeanconn commented Feb 6, 2019

Restating that we should get the version in the pickle somewhere (unless I'm missing it and it is already there).

@taldcroft
Copy link
Member Author

The "getting dark cal" and stars provenance turned out to be more difficult than I had hoped. Can you open a separate issue for just putting version in there?

@taldcroft
Copy link
Member Author

And milestone for 4.4.

@jeanconn
Copy link
Contributor

Ah, I'd forgotten version was handled in #271 because this issue was still open. So this issue is now just about the dark cal provenance.

@jeanconn jeanconn changed the title Include provenance information in pickle Include dark cal, agasc, and maybe agasc supplement version info in pickle Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants