Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow "mixed" inputs of an obsid + kwargs that uses mica.starcheck database #267

Open
taldcroft opened this issue Feb 11, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@taldcroft
Copy link
Member

From #256 (comment)

Change the API to disallow the "mixed" inputs case. Basically you can only get the mica.starcheck backend if only obsid is provided. If any other args are provided then it doesn't go that route. That makes it slightly harder in our development end but is then quite safe. I can make a helper function that does what the current code would have done for a mixed "obsid + other kwargs" case, to make it easy to get the necessary kwargs for a subsequent call of get_aca_catalog(**kwargs).

Aiming for 4.4, but at a lower priority than other issues. This might break some notebooks or code.

@taldcroft taldcroft added the enhancement New feature or request label Feb 11, 2019
@taldcroft taldcroft added this to the 4.4 milestone Feb 11, 2019
@taldcroft
Copy link
Member Author

This is a fine idea but since it may break some things, I'm pushing this off the 4.4 release.

@taldcroft taldcroft removed this from the 4.4 milestone Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant