Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check on guide image size #147

Open
jeanconn opened this issue Sep 29, 2020 · 2 comments
Open

Add check on guide image size #147

jeanconn opened this issue Sep 29, 2020 · 2 comments

Comments

@jeanconn
Copy link
Contributor

Add check on guide image size

If we're adding API to support selecting other image sizes

sot/proseco#344

this should probably be checked in sparkles (which will let us remove such checks from starcheck). Not sure if the defaults should be captured in a config in proseco.

@taldcroft
Copy link
Member

In sot/proseco#344 have made a new GuideTable.get_img_size() method that encapsulates the default and returns the "correct" answer for the catalog given the number of fids.

@jeanconn
Copy link
Contributor Author

Great idea! So we can get the size to double-check the catalog in sparkles and if we switch to 8x8 for ORs we only have one place to make a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants