Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to check observations with commanded 0 dither during acq #284

Open
jeanconn opened this issue Jan 17, 2019 · 2 comments
Open

Comments

@jeanconn
Copy link
Contributor

jeanconn commented Jan 17, 2019

For observations with monitor windows and observations approaching a dark cal, there can be acquisitions during the interval when commanded dither is 0 ampl or dither disable. Should starcheck use the previous dither (which may be the effective dither at the time of acquisition)?

For starcheck 13.0 it will be feeding proseco.get_acq_catalog with the commanded dither for these rare special-case observations.

@jeanconn jeanconn added this to the 13.1 milestone Jan 17, 2019
@jeanconn jeanconn modified the milestones: 13.1, 13.2 Mar 20, 2019
@taldcroft
Copy link
Member

Can this be closed? It looks like the decision has been made e.g. in 21681 in MAY1319.

@jeanconn
Copy link
Contributor Author

jeanconn commented May 8, 2019

I don't think we should close this, because IIRC, you weren't happy with the 0 choice? It is in the noise, but I think we should probably have a separate pad or some such because your point was that commanded 0 dither does not mean instantaneous 0 motion. But super low priority.

@jeanconn jeanconn removed this from the 13.2 milestone Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants