Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARKERS TUTORIAL: The tutorial does not end at the point where you are testing a beacon #56

Open
StevenAbrams opened this issue Aug 22, 2023 · 8 comments
Assignees
Labels
bug Something isn't working Priority 3 MEDIUM: The issue should be addressed soon, but it's not critical to the immediate goals. RESOLVED An issue that has been fixed and is ready to test can be set to Resolved. Severity 4 LOW: The issue has minimal impact on functionality or user experience.

Comments

@StevenAbrams
Copy link

Build: 1.0.0 (9)

Repro Steps:

  1. Go to Settings
  2. Select Help and Tutorials
  3. Select "Getting Started with Markers"
  4. Add your new Marker
  5. Test out the "Nearby Markers" button and confirm that you hear the Marker
  6. On the Experience Your World UI listen to the beacon

Expected Results:
You are able to point your phone towards your Markers and hear the beacon

Actual Results:
The beacon is not working and the tutorial does not complete to the end.

The user is left with the "Skip Tutorial" as the only option to exiting the tutorial

@StevenAbrams StevenAbrams added bug Something isn't working Priority 3 MEDIUM: The issue should be addressed soon, but it's not critical to the immediate goals. Severity 4 LOW: The issue has minimal impact on functionality or user experience. labels Aug 22, 2023
@Oliver2213
Copy link
Member

I've tested this in build 10 and it appears to be fixed now; the beacon properly appears for me, and when I center it the tutorial continues.
Please let me know if you can also confirm this.

@steinbro
Copy link
Member

Hm, it reliably does not work for me in the current TestFlight build, even though it did when I ran a test build directly on my phone. The commit that fixed the crash (f499cc5) involved moving a UI mutation from one thread to another, which means some nondeterminism is not unexpected. I'll need to do some more research into a more reliable fix.

steinbro added a commit that referenced this issue Aug 26, 2023
Change main.async to main.asyncAfter, like is done in beaconInBounds
@steinbro
Copy link
Member

I pushed a fix (at least for me, after I managed to reproduce it on my device). @Oliver2213, if the tutorial still works for you, we can include this in the next TestFlight.

@steinbro steinbro added the RESOLVED An issue that has been fixed and is ready to test can be set to Resolved. label Aug 26, 2023
@StevenAbrams
Copy link
Author

@steinbro I am just checking the bug. Not fixed in 1.0.0 (13),

@jchudge
Copy link

jchudge commented Oct 18, 2024

Feedback from user:
Issue 56, Markers Tutorial bug, has not been fully resolved. On my phone the tutorial works fine if I use the Places Nearby button when setting a marker, but it hangs when I use the search bar Choose Destination. Could it be because the search bar uses Apple Maps rather than Open Street Map, is that what is causing it to hang?

@jchudge jchudge assigned jchudge and unassigned Oliver2213 Oct 18, 2024
@JJGatchalian
Copy link
Contributor

I made that previous comment posted in October last year. I noticed that the beacon tutorial also hangs when using the search bar Choose Destination, but it proceeds normally when using the search filter Places Nearby. It could be that both the interactive beacon and marker tutorials have the same bug.

@RDMurray
Copy link
Contributor

This is failing here: DestinationTutorialIntroViewController.swift#L164

POIs from the mapKit search are currently not cached as far as I can tell. They use GenericLocation which according to the comments is "used for POIs that were created based on the user's current location"

I think to fix it we can fail over to AppContext.shared.spatialDataContext.destinationManager.setDestination(location: ...) if AppContext.shared.spatialDataContext.destinationManager.setDestination(entityKey: ...) fails.

@RDMurray
Copy link
Contributor

This isn't just a tutorial bug, the beacon only displays the name correctly if there is a ReferenceEntity in the database.

In normal use, if you set the beacon on a mapkit search result, it doesn't show the name of the destination. Instead it just shows location.

I've tried to figure this out for a while and haven't really got anywhere. Creating a temporary ReferenceEntity for the selected result doesn't work. setting temporary to false shows the name in the beacon correctly, but creates a marker for every search result selected.

Maybe I'll try again another time or someone else can take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority 3 MEDIUM: The issue should be addressed soon, but it's not critical to the immediate goals. RESOLVED An issue that has been fixed and is ready to test can be set to Resolved. Severity 4 LOW: The issue has minimal impact on functionality or user experience.
Projects
None yet
Development

No branches or pull requests

6 participants