-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MARKERS TUTORIAL: The tutorial does not end at the point where you are testing a beacon #56
Comments
I've tested this in build 10 and it appears to be fixed now; the beacon properly appears for me, and when I center it the tutorial continues. |
Hm, it reliably does not work for me in the current TestFlight build, even though it did when I ran a test build directly on my phone. The commit that fixed the crash (f499cc5) involved moving a UI mutation from one thread to another, which means some nondeterminism is not unexpected. I'll need to do some more research into a more reliable fix. |
Change main.async to main.asyncAfter, like is done in beaconInBounds
I pushed a fix (at least for me, after I managed to reproduce it on my device). @Oliver2213, if the tutorial still works for you, we can include this in the next TestFlight. |
@steinbro I am just checking the bug. Not fixed in 1.0.0 (13), |
Feedback from user: |
I made that previous comment posted in October last year. I noticed that the beacon tutorial also hangs when using the search bar Choose Destination, but it proceeds normally when using the search filter Places Nearby. It could be that both the interactive beacon and marker tutorials have the same bug. |
This is failing here: DestinationTutorialIntroViewController.swift#L164 POIs from the mapKit search are currently not cached as far as I can tell. They use I think to fix it we can fail over to |
This isn't just a tutorial bug, the beacon only displays the name correctly if there is a ReferenceEntity in the database. In normal use, if you set the beacon on a mapkit search result, it doesn't show the name of the destination. Instead it just shows location. I've tried to figure this out for a while and haven't really got anywhere. Creating a temporary ReferenceEntity for the selected result doesn't work. setting temporary to false shows the name in the beacon correctly, but creates a marker for every search result selected. Maybe I'll try again another time or someone else can take a look at it. |
Build: 1.0.0 (9)
Repro Steps:
Expected Results:
You are able to point your phone towards your Markers and hear the beacon
Actual Results:
The beacon is not working and the tutorial does not complete to the end.
The user is left with the "Skip Tutorial" as the only option to exiting the tutorial
The text was updated successfully, but these errors were encountered: