Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export useful CSS constants for modules to import #2668

Open
Cloud7050 opened this issue Sep 7, 2023 · 0 comments
Open

Export useful CSS constants for modules to import #2668

Cloud7050 opened this issue Sep 7, 2023 · 0 comments
Labels
Enhancement New feature request proposal Tentative suggestion inviting discussion

Comments

@Cloud7050
Copy link

Cloud7050 commented Sep 7, 2023

Modules usually spawn tabs, which contain their own defined elements and styling. Ideally, their design would be consistent with the rest of the frontend.

However, the frontend does not provide modules with CSS constants to import and reuse, such as for defining a consistent amount of spacing, sharing the same Blueprint border radius, or reusing an existing Ace editor theme colour.

A current way of working around this is to inspect the frontend webpage and extract relevant strings for reuse, storing them in the modules repo itself. These are duplicate values that need to be manually updated (eg when we updated to BlueprintJS V4), akin to copy pasting the js-slang List library into various modules (we now have the technology to not require doing so).

This enhancement entails exporting some useful CSS constants from the frontend such that modules are able to import them.

(This is a followup to a review comment in source-academy/modules#234.)

@Cloud7050 Cloud7050 added Enhancement New feature request proposal Tentative suggestion inviting discussion labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature request proposal Tentative suggestion inviting discussion
Projects
No open projects
Development

No branches or pull requests

1 participant