-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple Playground from SICP Workspace #2487
base: master
Are you sure you want to change the base?
Decouple Playground from SICP Workspace #2487
Conversation
Pull Request Test Coverage Report for Build 5010569236Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Replaces isSicpEditor with the literal `true` and simplify the conditionals that involve it. This results in removal of features such as the remote execution tab and the shared session buttons.
Replaces isSicpEditor with the literal `false` and simplify the conditionals that involve it.
Removes from SicpWorkspace remaining query string handling logic that was only used for remote execution (`shouldAddDevice` param).
This PR will first require the language config object to be moved from a hardcoded Playground state to be under the workspace context instead. Currently, the SICP Workspace still inherits and affects the state of the Playground, so this should not be merged yet. |
The overall direction of this PR looks good. I'll look through the final version of this PR thoroughly since it's mostly checking that the workspaces are separated correctly. |
…y-frontend into 23-summer/decouple-playground-sicp
Partially reverts 2243494 in preparation for merging of commits from refactoring change. Done simply to prevent as many merge conflicts as possible. Changes are to be restored later.
…y-frontend into 23-summer/decouple-playground-sicp
…y-frontend into 23-summer/decouple-playground-sicp
…y-frontend into 23-summer/decouple-playground-sicp
…y-frontend into 23-summer/decouple-playground-sicp
Description
The tight coupling is blocking a couple planned changes related to refactoring to make use of language configs.
Fixes #2410.
Type of change
How to test
Checklist