Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix to speed up canAvoidInstr #1699

Merged
merged 14 commits into from
Apr 29, 2024
Merged

Temporary fix to speed up canAvoidInstr #1699

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
da818e4
check if env instruction is necessary
DiligentPenguinn Apr 22, 2024
de09673
Add test cases
DiligentPenguinn Apr 22, 2024
4d26880
Implement helper functions
DiligentPenguinn Apr 22, 2024
067bc95
Fix format
DiligentPenguinn Apr 22, 2024
95c5e7d
Cache isEnvDependent results
DiligentPenguinn Apr 27, 2024
432b1a8
Delete unnecessary comments
DiligentPenguinn Apr 27, 2024
0e0f5db
Merge branch 'master' into cse-machine-simplify-env-instr
DiligentPenguinn Apr 27, 2024
04917eb
Merge branch 'master' into cse-machine-simplify-env-instr
DiligentPenguinn Apr 27, 2024
5504278
Merge branch 'master' into cse-machine-simplify-env-instr
DiligentPenguinn Apr 27, 2024
5e2f015
Speed up env dependent checking, approach 2
DiligentPenguinn Apr 27, 2024
1dd9845
Merge branch 'cse-machine-simplify-env-instr' of https://github.com/s…
DiligentPenguinn Apr 27, 2024
b88ad72
merge
DiligentPenguinn Apr 27, 2024
eca7bbf
Address my comments
RichDom2185 Apr 29, 2024
350ea87
Merge branch 'master' into cse-machine-simplify-env-instr
RichDom2185 Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/cse-machine/__tests__/__snapshots__/cse-machine-heap.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ EnvTree {
],
"callee": Node {
"end": 90,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -177,6 +178,7 @@ EnvTree {
"type": "Identifier",
},
"end": 101,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 12,
Expand Down Expand Up @@ -783,6 +785,7 @@ EnvTree {
],
"callee": Node {
"end": 90,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -798,6 +801,7 @@ EnvTree {
"type": "Identifier",
},
"end": 101,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 12,
Expand Down Expand Up @@ -1428,6 +1432,7 @@ EnvTree {
],
"callee": Node {
"end": 90,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -1443,6 +1448,7 @@ EnvTree {
"type": "Identifier",
},
"end": 101,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 12,
Expand Down Expand Up @@ -2094,6 +2100,7 @@ EnvTree {
],
"callee": Node {
"end": 90,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -2109,6 +2116,7 @@ EnvTree {
"type": "Identifier",
},
"end": 101,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 12,
Expand Down Expand Up @@ -2485,6 +2493,7 @@ EnvTree {
],
"callee": Node {
"end": 90,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -2500,6 +2509,7 @@ EnvTree {
"type": "Identifier",
},
"end": 101,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 12,
Expand Down Expand Up @@ -2663,6 +2673,7 @@ EnvTree {
],
"callee": Node {
"end": 90,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -2678,6 +2689,7 @@ EnvTree {
"type": "Identifier",
},
"end": 101,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 12,
Expand Down Expand Up @@ -5600,6 +5612,7 @@ EnvTree {
],
"callee": Node {
"end": 24,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -5615,6 +5628,7 @@ EnvTree {
"type": "Identifier",
},
"end": 33,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 10,
Expand Down Expand Up @@ -6058,6 +6072,7 @@ EnvTree {
],
"callee": Node {
"end": 24,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -6073,6 +6088,7 @@ EnvTree {
"type": "Identifier",
},
"end": 33,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 10,
Expand Down Expand Up @@ -6525,6 +6541,7 @@ EnvTree {
],
"callee": Node {
"end": 24,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -6540,6 +6557,7 @@ EnvTree {
"type": "Identifier",
},
"end": 33,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 10,
Expand Down Expand Up @@ -6891,6 +6909,7 @@ EnvTree {
],
"callee": Node {
"end": 24,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -6906,6 +6925,7 @@ EnvTree {
"type": "Identifier",
},
"end": 33,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 10,
Expand Down Expand Up @@ -7060,6 +7080,7 @@ EnvTree {
],
"callee": Node {
"end": 24,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -7075,6 +7096,7 @@ EnvTree {
"type": "Identifier",
},
"end": 33,
"isEnvDependent": true,
"loc": SourceLocation {
"end": Position {
"column": 10,
Expand Down Expand Up @@ -7431,6 +7453,7 @@ EnvTree {
},
],
"callee": Object {
"isEnvDependent": false,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -7444,6 +7467,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down Expand Up @@ -8275,6 +8299,7 @@ EnvTree {
},
],
"callee": Object {
"isEnvDependent": false,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -8288,6 +8313,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down Expand Up @@ -9218,6 +9244,7 @@ EnvTree {
},
],
"callee": Object {
"isEnvDependent": false,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -9231,6 +9258,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down Expand Up @@ -10180,6 +10208,7 @@ EnvTree {
},
],
"callee": Object {
"isEnvDependent": false,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -10193,6 +10222,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down Expand Up @@ -10932,6 +10962,7 @@ EnvTree {
},
],
"callee": Object {
"isEnvDependent": false,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -10945,6 +10976,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down Expand Up @@ -11183,6 +11215,7 @@ EnvTree {
},
],
"callee": Object {
"isEnvDependent": false,
"loc": SourceLocation {
"end": Position {
"column": 1,
Expand All @@ -11196,6 +11229,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down
Loading
Loading