New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide stories/associations from deleted users #76

Open

RichDom2185 opened this issue Jul 26, 2023 · 1 comment

Member

RichDom2185 commented Jul 26, 2023

Current behavior: The ID is still visible, but all fields will return blank.

This was referenced Jul 26, 2023

Disallow creation of new stories by deleted users #77

Open

Add DELETE routes #78

Merged

Member Author

RichDom2185 commented Jul 26, 2023

@YaleChen299 which do you think is/are best/better:

When deleting a user, also delete all their stories (in the permissions check in Setup CRUD permissions check #74, thus we need to ensure it's AllOf{ can delete user, can delete stories })
Add a filter in stories controllers to those coming from non-deleted users only (but this introduces some coupling)
Some combination of both?

I'm inclined to the first option but not fully. Might need to think this through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment