Refactor DB scripts #106
Merged
Refactor DB scripts #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value of a string variable is already an empty string, and there was no additional error handling done.
Allows for better abstraction and improves reusability.
Reduces code duplication.
Makes the name more descriptive.
Prevents bugs.
Hides implementation details of the config object as the function only needs to be aware of the database name to create, not how it is derived from.
Similar to createDB, this improves abstraction.
Improves single responsibility.
* Move happy path to outside if condition * Simplify error handling * Update logging behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the commit history for the list of changes.
Part of #14.