Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect package name and version normalization #92

Closed
varungandhi-src opened this issue Aug 18, 2023 · 0 comments · Fixed by #99
Closed

Incorrect package name and version normalization #92

varungandhi-src opened this issue Aug 18, 2023 · 0 comments · Fixed by #99
Labels
bug Something isn't working

Comments

@varungandhi-src
Copy link
Contributor

varungandhi-src commented Aug 18, 2023 •
edited
Loading

https://sourcegraph.com/github.com/sourcegraph/scip-python/-/blob/packages/pyright-scip/src/ScipSymbol.ts?L10-11

^ The logic here is incorrect. It should follow the description in https://github.com/sourcegraph/scip/blob/main/scip.proto#L118-L121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Normalize name and version correctly sourcegraph/scip-python
1 participant
@varungandhi-src