Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scip-ruby-arm64-linux builds #228

Open
qaisjp opened this issue Oct 30, 2024 · 1 comment
Open

scip-ruby-arm64-linux builds #228

qaisjp opened this issue Oct 30, 2024 · 1 comment
Labels

Comments

@qaisjp
Copy link

qaisjp commented Oct 30, 2024

Problem

Stripe makes contributions to Sorbet and uses the HEAD version of Sorbet internally. Our scip-ruby CI job is set up to pass the exact same flags that we pass to sorbet, into scip-ruby.

When the Sorbet team changes CLI flags and bumps the version of Sorbet used internally, all tests pass, even though scip-ruby doesn't support the extra flags. That's because we only run scip-ruby CI job every 30m, instead on every push.

Then, later I find out that the scip-ruby CI job is failing because of ~"unknown CLI arguments".

So I've been (after the fact) patching the sorbet config in our scip-ruby CI job using something like this:

# Mod the Sorbet config to replace `--uniquely-defined-behavior` with `--stripe-mode`
sed -i 's/--uniquely-defined-behavior/--stripe-mode/' sorbet/config
# Delete the `--extra-package-files-directory-prefix-slash-deprecated` line
sed -i '/--extra-package-files-directory-prefix-slash-deprecated/d' sorbet/config
sed -i '/--extra-package-files-directory-prefix-slash-deprecated/d' sorbet/extra-package-directories.txt
# Delete the line starting with `--packager-layers`
sed -i '/--packager-layers/d' sorbet/config

This is kind of a cat-and-mouse game, so I'd like to make it so that when the Sorbet team bumps the Sorbet version, we run a test specifically checking that the flags are valid with scip-ruby too.

Our CI environment runs arm64 and x86_64 randomly but for Linux we only have x86_64 builds.

So I can't write the test until we have Linux arm64 builds :(

Suggested solution

https://github.com/sourcegraph/scip-ruby/releases/tag/scip-ruby-v0.4.3 currently scip-ruby-x86_64-linux and I would love a scip-ruby-arm64-linux too please

Compared to other tools

No response

OSS Examples

No response

@qaisjp qaisjp added the enhancement New feature or request label Oct 30, 2024
Copy link

linear bot commented Oct 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant