You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Stripe makes contributions to Sorbet and uses the HEAD version of Sorbet internally. Our scip-ruby CI job is set up to pass the exact same flags that we pass to sorbet, into scip-ruby.
When the Sorbet team changes CLI flags and bumps the version of Sorbet used internally, all tests pass, even though scip-ruby doesn't support the extra flags. That's because we only run scip-ruby CI job every 30m, instead on every push.
Then, later I find out that the scip-ruby CI job is failing because of ~"unknown CLI arguments".
So I've been (after the fact) patching the sorbet config in our scip-ruby CI job using something like this:
# Mod the Sorbet config to replace `--uniquely-defined-behavior` with `--stripe-mode`
sed -i 's/--uniquely-defined-behavior/--stripe-mode/' sorbet/config
# Delete the `--extra-package-files-directory-prefix-slash-deprecated` line
sed -i '/--extra-package-files-directory-prefix-slash-deprecated/d' sorbet/config
sed -i '/--extra-package-files-directory-prefix-slash-deprecated/d' sorbet/extra-package-directories.txt
# Delete the line starting with `--packager-layers`
sed -i '/--packager-layers/d' sorbet/config
This is kind of a cat-and-mouse game, so I'd like to make it so that when the Sorbet team bumps the Sorbet version, we run a test specifically checking that the flags are valid with scip-ruby too.
Our CI environment runs arm64 and x86_64 randomly but for Linux we only have x86_64 builds.
So I can't write the test until we have Linux arm64 builds :(
Problem
Stripe makes contributions to Sorbet and uses the HEAD version of Sorbet internally. Our scip-ruby CI job is set up to pass the exact same flags that we pass to
sorbet
, intoscip-ruby
.When the Sorbet team changes CLI flags and bumps the version of Sorbet used internally, all tests pass, even though scip-ruby doesn't support the extra flags. That's because we only run scip-ruby CI job every 30m, instead on every push.
Then, later I find out that the scip-ruby CI job is failing because of ~"unknown CLI arguments".
So I've been (after the fact) patching the sorbet config in our scip-ruby CI job using something like this:
This is kind of a cat-and-mouse game, so I'd like to make it so that when the Sorbet team bumps the Sorbet version, we run a test specifically checking that the flags are valid with scip-ruby too.
Our CI environment runs arm64 and x86_64 randomly but for Linux we only have x86_64 builds.
So I can't write the test until we have Linux arm64 builds :(
Suggested solution
https://github.com/sourcegraph/scip-ruby/releases/tag/scip-ruby-v0.4.3 currently scip-ruby-x86_64-linux and I would love a
scip-ruby-arm64-linux
too pleaseCompared to other tools
No response
OSS Examples
No response
The text was updated successfully, but these errors were encountered: