-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplicate Documents for same file #330
Comments
Hmm, I tried indexing the linked repo with the bad paths, and I cannot reproduce the issue:
Would need to look deeper into where these bad paths are coming from. |
Another instance of this here: https://github.com/sourcegraph/sourcegraph/issues/61245 |
Something interesting:
Even though the same index should be getting uploaded to both places. |
I believe a minimal repo that will have this issue is shown in this sample I made. The key is having a child folder that uses the references node in tsconfig to refer to the parent folder. |
Originally flagged by @Strum355 in Slack:
It looks like we emit multiple SCIP Documents in the same Index for the same file, but with different relative paths. Out of these, some relative paths are wrong because they are not normalized.
We should make sure to normalize all relative paths and not do duplicate work for the same file.
Example URL
Scope
The text was updated successfully, but these errors were encountered: