Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor planner filter logic #3253

Open
nasdf opened this issue Nov 18, 2024 · 2 comments
Open

Refactor planner filter logic #3253

nasdf opened this issue Nov 18, 2024 · 2 comments
Labels
refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone

Comments

@nasdf
Copy link
Member

nasdf commented Nov 18, 2024

Move the planner filtering logic to a Filter node.

@nasdf nasdf added the refactor This issue specific to or requires *notable* refactoring of existing codebases and components label Nov 18, 2024
@nasdf nasdf added this to the DefraDB v0.15 milestone Nov 18, 2024
@nasdf nasdf self-assigned this Nov 18, 2024
nasdf added a commit that referenced this issue Dec 5, 2024
## Relevant issue(s)

Resolves #3195

## Description

This PR enables aggregate alias targeting in filters.

Blocked by #3253

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

Added and updated integration tests.

Specify the platform(s) on which this was tested:
- MacOS
@nasdf nasdf removed their assignment Dec 5, 2024
@mahmudsudo
Copy link

can i take on this ?

@nasdf
Copy link
Member Author

nasdf commented Dec 9, 2024

can i take on this ?

You are welcome to put together a PR. I wouldn't recommend this as a first time contributor issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Development

No branches or pull requests

2 participants