You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the updated rust core, we need to go through and rationalize (and unify) rust and python code so we don't, for example, create sigs/zips that break rust assumptions.
from luiz: rust and python should support same ops. I started unifying a bunch of the code in #2728 but at this point that's very outdated
The text was updated successfully, but these errors were encountered:
I think this will happen naturally as long as we pay attention to the Python tests; there are a lot of tests for corner cases at fairly high API levels (usually the CLI). An unanticipated benefit of functional tests over unit tests I guess? :)
I do think this provides a pretty good argument and incentive for more strongly prioritizing integration of branchwater-plugin-style speed and functionality into the core sourmash package. FBFW, the sourmash Python layer is pretty thoroughly tested, while the branchwater plugin is pretty light on tests.
With the updated rust core, we need to go through and rationalize (and unify) rust and python code so we don't, for example, create sigs/zips that break rust assumptions.
from luiz: rust and python should support same ops. I started unifying a bunch of the code in #2728 but at this point that's very outdated
The text was updated successfully, but these errors were encountered: