Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rationalize python and rust code #2949

Open
bluegenes opened this issue Jan 27, 2024 · 2 comments
Open

rationalize python and rust code #2949

bluegenes opened this issue Jan 27, 2024 · 2 comments

Comments

@bluegenes
Copy link
Contributor

With the updated rust core, we need to go through and rationalize (and unify) rust and python code so we don't, for example, create sigs/zips that break rust assumptions.

from luiz: rust and python should support same ops. I started unifying a bunch of the code in #2728 but at this point that's very outdated

@ctb
Copy link
Contributor

ctb commented Jan 27, 2024

I think this will happen naturally as long as we pay attention to the Python tests; there are a lot of tests for corner cases at fairly high API levels (usually the CLI). An unanticipated benefit of functional tests over unit tests I guess? :)

I do think this provides a pretty good argument and incentive for more strongly prioritizing integration of branchwater-plugin-style speed and functionality into the core sourmash package. FBFW, the sourmash Python layer is pretty thoroughly tested, while the branchwater plugin is pretty light on tests.

@luizirber
Copy link
Member

from luiz: rust and python should support same ops. I started unifying a bunch of the code in #2728 but at this point that's very outdated

Note this was a comment on KmerMinHash/KmerMinHashBTree on the Rust side, not across Python/Rust.

But it is connected on the Frozen/Mutable discussion between Python/Rust, since in general Frozen == KmerMinHash and Mutable == KmerMinHashBTree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants