WIP: check for unknown kwargs in Index.select
#2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## try-submanifest #2663 +/- ##
===================================================
+ Coverage 92.64% 92.84% +0.19%
===================================================
Files 104 104
Lines 12403 12412 +9
Branches 2610 2616 +6
===================================================
+ Hits 11491 11524 +33
+ Misses 613 587 -26
- Partials 299 301 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
luizirber
reviewed
Sep 4, 2023
Comment on lines
+52
to
+58
| def _check_for_unknown_select_params(kwargs): | ||
| legit_param_names = { 'ksize', 'moltype', 'scaled', 'num', 'abund', | ||
| 'containment', 'picklist', 'filter_manifest' } # @CTB picklist | ||
| kk = set(kwargs.keys()) | ||
| assert kk.issubset(legit_param_names), kk - legit_param_names | ||
|
|
||
|
|
There was a problem hiding this comment.
Might be relevant: in #2726 I defined a Selection TypedDict to be able to
- use type checking
- being able to more easily convert a selection to Rust (the
_selection_as_rustfunction).
Then the method signature for select becomes
def select(self, **kwargs: Unpack[Selection]):
(This is slightly annoying because the select method needs to extract the values from kwargs...)
PEP-692 has more details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: PR into #2602
This PR adds a check for unknown kwargs into (most)
Index.selectcalls, addressing #2259.This is part of my review of #2602, where I was worried about whether all Index objects supported filter_manifest :).