Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove methods that allocate, prefer iterators instead #3056

Draft
wants to merge 8 commits into
base: latest
Choose a base branch
from

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Mar 3, 2024

#3047 will need a new version bump, bringing in these changes because they also need a version bump

  • Remove sketches method from Signature, use iter method instead -> core: find replacement for .sketches()? #2977
  • Remove mins method from MinHash, use iter_mins method instead
  • Add benchmarks for jaccard and count_common
  • add_many takes an iterator now, similar to remove_many
  • Add size_hint for Intersection iterator

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 86.88%. Comparing base (24ab89c) to head (2d0dc0f).

Files Patch % Lines
src/core/src/sketch/minhash.rs 54.54% 5 Missing ⚠️
src/core/src/sketch/nodegraph.rs 0.00% 4 Missing ⚠️
src/core/src/sketch/hyperloglog/mod.rs 0.00% 2 Missing ⚠️
src/core/src/ffi/minhash.rs 0.00% 1 Missing ⚠️
src/core/src/index/linear.rs 0.00% 1 Missing ⚠️
src/core/src/index/revindex/disk_revindex.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3056   +/-   ##
=======================================
  Coverage   86.88%   86.88%           
=======================================
  Files         136      136           
  Lines       15543    15545    +2     
  Branches     2637     2637           
=======================================
+ Hits        13505    13507    +2     
  Misses       1736     1736           
  Partials      302      302           
Flag Coverage Δ
hypothesis-py 25.44% <ø> (ø)
python 92.87% <ø> (ø)
rust 61.47% <65.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant