Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: add Manifest::intersect_manifest to Rust core #3305

Merged
merged 40 commits into from
Sep 21, 2024
Merged

MRG: add Manifest::intersect_manifest to Rust core #3305

merged 40 commits into from
Sep 21, 2024

Commits on Aug 21, 2024

  1. make error catchable

    @ctb
    ctb committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    6b1d1bb View commit details
    Browse the repository at this point in the history

  2. flag another problematic unwrap

    @ctb
    ctb committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7e73e8f View commit details
    Browse the repository at this point in the history

  3. more

    @ctb
    ctb committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2896c49 View commit details
    Browse the repository at this point in the history

  4. more

    @ctb
    ctb committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    45b1a8f View commit details
    Browse the repository at this point in the history

  5. upd log message

    @ctb
    ctb committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    e8d7999 View commit details
    Browse the repository at this point in the history

  6. provide correct error

    @ctb
    ctb committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    53bcf02 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. switch Manifest from paths to TryFrom

    @ctb
    ctb committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d467d9f View commit details
    Browse the repository at this point in the history

  2. Revert "provide correct error" 

    This reverts commit 53bcf02.
    @ctb
    ctb committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5f1eef6 View commit details
    Browse the repository at this point in the history

  3. Revert "switch Manifest from paths to TryFrom" 

    This reverts commit d467d9f.
    @ctb
    ctb committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    eb46ecd View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. poor person's picklist?

    @ctb
    ctb committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    923af44 View commit details
    Browse the repository at this point in the history

  2. add picklist select

    @ctb
    ctb committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    315dfff View commit details
    Browse the repository at this point in the history

  3. ok

    @ctb
    ctb committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    1fb658a View commit details
    Browse the repository at this point in the history

  4. picklist by ref

    @ctb
    ctb committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a122982 View commit details
    Browse the repository at this point in the history

  5. add manifest.is_empty()

    @ctb
    ctb committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    39816ab View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. update revindex indexing message

    @ctb
    ctb committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    61416fb View commit details
    Browse the repository at this point in the history

  2. propagate error on bad directory when opening RocksDB

    @ctb
    ctb committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    3a7abe9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'update_revindex' into remove_unwrap

    @ctb
    ctb committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    07e3a09 View commit details
    Browse the repository at this point in the history

  4. do we not need len?

    @ctb
    ctb committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    fe75c6c View commit details
    Browse the repository at this point in the history

  5. nope, don't need em

    @ctb
    ctb committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    5fb20fc View commit details
    Browse the repository at this point in the history

  6. revert for now

    @ctb
    ctb committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    2c59010 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'latest' of github.com:sourmash-bio/sourmash into remove… 

    …_unwrap
    @ctb
    ctb committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c8477df View commit details
    Browse the repository at this point in the history

  2. adjust select_picklist per luiz

    @ctb
    ctb committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6fee403 View commit details
    Browse the repository at this point in the history

  3. simplify and encapsulate

    @ctb
    ctb committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0675402 View commit details
    Browse the repository at this point in the history

  4. cargo fmt

    @ctb
    ctb committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    17f50ef View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. add a test of intersect_manifest

    @ctb
    ctb committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    39c140b View commit details
    Browse the repository at this point in the history

  2. impl PartialEq/Eq for Record, ignoring internal_location

    @ctb
    ctb committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    16f72c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. switch to using full Record for intersect_manifest

    @ctb
    ctb committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2146f30 View commit details
    Browse the repository at this point in the history

  2. round out comparison & hashing for Record

    @ctb
    ctb committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    32839ae View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @ctb
    ctb committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    43ee757 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'latest' into remove_unwrap

    @ctb
    ctb authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    31aa378 View commit details
    Browse the repository at this point in the history

  5. remove identity closure

    @ctb
    ctb committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1594dc4 View commit details
    Browse the repository at this point in the history

  6. add in a print for debugging

    @ctb
    ctb committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2465c02 View commit details
    Browse the repository at this point in the history

  7. more print

    @ctb
    ctb committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5af5f45 View commit details
    Browse the repository at this point in the history

  8. remove prints

    @ctb
    ctb committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b46565d View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge branch 'latest' of github.com:sourmash-bio/sourmash into remove… 

    …_unwrap
    @ctb
    ctb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b7a9850 View commit details
    Browse the repository at this point in the history

  2. add a test for Collection::intersect_manifest

    @ctb
    ctb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9c26752 View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @ctb
    ctb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f2fde5d View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. modify intersect_manifest signature

    @ctb
    ctb committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f4e89f4 View commit details
    Browse the repository at this point in the history

  2. mut Collection for intersect_manifest

    @ctb
    ctb committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9b9e17e View commit details
    Browse the repository at this point in the history

  3. omit unit return type

    @ctb
    ctb committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    aa109f8 View commit details
    Browse the repository at this point in the history