MRG: add Manifest::intersect_manifest to Rust core

src/core/src/collection.rs

@@ -2,6 +2,7 @@
 
 use camino::Utf8Path as Path;
 use camino::Utf8PathBuf as PathBuf;
+use std::collections::HashSet;
 
 use crate::encodings::Idx;
 use crate::manifest::{Manifest, Record};
@@ -215,6 +216,12 @@
         assert_eq!(sig.signatures.len(), 1);
         Ok(sig)
     }
+
+    pub fn select_picklist(&self, pick: &HashSet<(String, String)>) -> Self {
+        // @CTB: why do we need this clone here?
+        let manifest = self.manifest.clone().select_picklist(pick);
+        Self { manifest, storage: self.storage.clone() }
+    }
 }
 
 impl Select for Collection {
@@ -236,7 +243,7 @@
     use crate::prelude::Select;
     use crate::selection::Selection;
     use crate::signature::Signature;
     use crate::Result;
 
     #[test]
     fn sigstore_selection_with_downsample() {

src/core/src/index/revindex/disk_revindex.rs

@@ -114,7 +114,7 @@ impl RevIndex {
 
         info!("Compact SSTs");
         index.compact();
-        info!("Processed {} reference sigs", processed_sigs.into_inner());
+        info!("Done! Processed {} reference sigs", processed_sigs.into_inner());
 
         Ok(module::RevIndex::Plain(index))
     }

src/core/src/index/revindex/mod.rs

@@ -186,7 +186,7 @@ impl RevIndex {
 
     pub fn open<P: AsRef<Path>>(index: P, read_only: bool, spec: Option<&str>) -> Result<Self> {
         let opts = db_options();
-        let cfs = DB::list_cf(&opts, index.as_ref()).unwrap();
+        let cfs = DB::list_cf(&opts, index.as_ref())?;
 
         if cfs.into_iter().any(|c| c == COLORS) {
             // TODO: ColorRevIndex can't be read-only for now,
@@ -1020,4 +1020,14 @@ mod test {
 
         Ok(())
     }
+
+    #[test]
+    fn rocksdb_storage_fail_bad_directory() -> Result<()> {
+        let testdir = TempDir::new()?;
+
+        match RevIndex::open(testdir, true, None) {
+            Err(_) => Ok(()),
+            Ok(_) => panic!("test should not reach here"),
+        }
+    }
 }

src/core/src/manifest.rs

@@ -8,6 +8,7 @@
 use rayon::prelude::*;
 use serde::de;
 use serde::{Deserialize, Serialize};
+use std::collections::HashSet;
 
 use crate::encodings::HashFunctions;
 use crate::prelude::*;
@@ -209,6 +210,14 @@
     pub fn iter(&self) -> impl Iterator<Item = &Record> {
         self.records.iter()
     }
+
+    pub fn select_picklist(self, pick: &HashSet<(String, String)>) -> Self {
+        let records = self.records.iter().filter(|row| {
+            pick.contains(&(row.name().clone(), row.md5().clone()))
+        }).cloned().collect();
+
+        Self { records }
+    }
 }
 
 impl Select for Manifest {