Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new core manifest struct and functions in manysketch #203

Closed
bluegenes opened this issue Feb 2, 2024 · 0 comments · Fixed by #217
Closed

use new core manifest struct and functions in manysketch #203

bluegenes opened this issue Feb 2, 2024 · 0 comments · Fixed by #217

Comments

@bluegenes
Copy link
Contributor

bluegenes commented Feb 2, 2024 •
edited
Loading

follows up on #196

One quirk that we might want to handle/modify:

sourmash expects booleans in manifests to be 'True/False' and doesn't accept true/false? Noticed b/c serde's serialization uses lowercase in accordance with json, but not converting to True/False yields erros. We should consider allowing either.
@bluegenes bluegenes mentioned this issue Feb 2, 2024
Merged
This was referenced Feb 16, 2024
Merged
Merged
bluegenes added a commit that referenced this issue Feb 23, 2024
@bluegenes
MRG: Use core manifest utils (#217)
43caeba 
This PR updates manifest generation in `manysketch` to use `Record` and `Manifest` utils from core. This also makes the code significantly simpler, since we can generate manifest information directly from the signature, rather than saving sketch parameters alongside sketches. 

Required `0.13.0` core due to these fixes:
- sourmash-bio/sourmash#3007
- sourmash-bio/sourmash#3019

* Fixes #203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MRG: Use core manifest utils sourmash-bio/sourmash_plugin_branchwater
1 participant
@bluegenes