Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix signature reporting for index #376

Closed
bluegenes opened this issue Jul 2, 2024 · 1 comment
Closed

fix signature reporting for index #376

bluegenes opened this issue Jul 2, 2024 · 1 comment

Comments

@bluegenes
Copy link
Contributor

bluegenes commented Jul 2, 2024

with changes from #359, we now see the following when running sourmash scripts index:

== This is sourmash version 4.8.10. ==
== Please cite Irber et. al (2024), doi:10.21105/joss.06830. ==
ksize: 31 / scaled: 50 / moltype: DNA 
indexing all sketches in 'ralstonia32.zip'
Reading analysis(s) from: 'ralstonia32.zip'

"analysis" used to be "signature". We could now add "signature" in for better description, --> Reading analysis signature(s) from: 'ralstonia32.zip'

@ctb
Copy link
Collaborator

ctb commented Oct 26, 2024

Current behavior seems acceptable:

% sourmash scripts pairwise list3.txt -o xyz.csv
== This is sourmash version 4.8.11. ==
== Please cite Irber et. al (2024), doi:10.21105/joss.06830. ==

=> sourmash_plugin_branchwater 0.9.8; cite Irber et al., doi: 10.1101/2022.11.02.514947

ksize: 31 / scaled: 1000 / moltype: DNA / threshold: 0.01
pairwise-comparing all sketches in 'list3.txt' using 8 threads
Reading analysis(s) from: 'list3.txt'
SUCCEEDED in loading as JSON files, woot woot
Loaded 3 analysis signature(s)
DONE. Processed 3 comparisons
...pairwise is done! results in 'xyz.csv'

specifically: "Loaded 3 analysis signature(s)"

I think this was fixed in #430

@ctb ctb closed this as completed Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants