Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor, test, and benchmark different scaled factors across the plugin #510

Open
ctb opened this issue Nov 11, 2024 · 0 comments
Open

Comments

@ctb
Copy link
Collaborator

ctb commented Nov 11, 2024

#504 fixes a bunch of issues where scaled was not being set properly, ref sourmash-bio/sourmash#3384. This led to inconsistent gather results per #505.

once we reach a good resting point with the sourmash decisions in sourmash-bio/sourmash#3384 and maybe sourmash-bio/sourmash#3355 and maybe #501 we should refactor the code, re-evaluate the tests, and benchmark with different scaled factors for both query and db; in large part this is worth doing because a large part of the point of being able to decrease scaled is that it should lead to much faster searches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant