Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: update docs and -h messages for v0.9.5 release #364

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Conversation

ctb
Copy link
Collaborator

@ctb ctb commented Jun 19, 2024

This PR follows #360 and #361, which fix the gather output to be ~100% sourmash compatible.

This PR:

Fixes #329
Fixes #350
Fixes #362

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggested changes, but otherwise lgtm!

README.md Outdated Show resolved Hide resolved

The main advantage that `fastmultigather` has over running `fastgather` on multiple queries is that you only load the database files once with `fastmultigather`, which can be a significant time savings for large databases!
The main advantage that `fastmultigather` has over running `fastgather` on multiple queries is that `fastmultigather` only needs to load the database once for all queries, unlike with `fastgather`; this can be a significant time savings for large databases!

#### Output files for `fastmultigather`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this section, should we now add some text on how rocksdb fastmultigather differs (single output file for all results, no prefetch)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in 0f6a077

@ctb ctb enabled auto-merge (squash) June 19, 2024 14:18
@ctb ctb merged commit c67bb82 into main Jun 19, 2024
1 check passed
@ctb ctb deleted the update_docs_095 branch June 19, 2024 14:31
@ctb ctb mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants