Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to update redis config after first run? #314

Closed
ifeltsweet opened this issue Feb 6, 2017 · 8 comments
Closed

How to update redis config after first run? #314

ifeltsweet opened this issue Feb 6, 2017 · 8 comments

Comments

@ifeltsweet
Copy link

Isn't breadcrumb approach only needed for sentinel config? Why is it applied for redis config too? From reading Redis documentation I thought only sentinel config is being automatically updated with current state. You also seem to say so yourself:

Redis-sentinel will write configuration and state data back into its configuration file. This creates obvious problems when that config is managed by chef. This cookbook will create the config file once, and then leave a breadcrumb that will guard against the file from being updated again.

If I am wrong and breadcrumb is needed for redis config too then what is the suggested procedure to update configuration variables after first run via this cookbook?

@bliuchak
Copy link

bliuchak commented Feb 7, 2017

i've also encountered with the same problem. I was unable to update "default_settings" for redis because of .breadcrumb file.

@brianbianco
Copy link
Contributor

Yes, breadcrumb should only be for sentinel. This is an error if its happening with anything else.

@bliuchak
Copy link

bliuchak commented Feb 7, 2017

@brianbianco I can confirm that after chef-client run I have slave.conf.breadcrumb and sentinel.conf.breadcrumb.

I guess that this problem is because of changes in this merge request #232 (see providers/configure.rb)

@sleenen
Copy link

sleenen commented Mar 13, 2017

How can/should I make changes to existing config now then? Is this issue being handled?

@shortdudey123
Copy link
Contributor

shortdudey123 commented Apr 25, 2017

The breadcrumb is needed for both sentinel and the redis slave itself since both config's are dynamically written by sentinel. Currently i handle it by manually deleting the breadcrumb and running chef on one host at a time with the master being last.

That being said, the breadcrumb file is only needed on the redis slave if you have sentinel installed.

#318 was already created to track updating the redis config with sentinel dynamically after the initial creation without overriding the CONFIG REWRITE section

@poloka
Copy link

poloka commented Aug 13, 2018

I'd like to see a fix for the breadcrumb concept. The initial PR missed updating the sentinel recipe so now I'm stuck having to manually delete this breadcrumb file in order to complete my chef run. I tested this out with even setting default['redisio']['default_settings']['breadcrumb'] to false.

@xorima
Copy link
Contributor

xorima commented May 11, 2019

Closing due to inactivity.

If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!

Thanks,
Sous-Chefs

@xorima xorima closed this as completed May 11, 2019
@lock
Copy link

lock bot commented Aug 8, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants