Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hideDock does not work on Windows 10 #45

Open
2 tasks done
DRSDavidSoft opened this issue Oct 31, 2018 · 6 comments
Open
2 tasks done

hideDock does not work on Windows 10 #45

DRSDavidSoft opened this issue Oct 31, 2018 · 6 comments

Comments

@DRSDavidSoft
Copy link

DRSDavidSoft commented Oct 31, 2018

  • I am on the latest hyperterm-summon version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10 v1803 – build 17134
  • Hyper.exe version: 2.0.0.1008
  • hyperterm-summon version: 2.0.9
  • Link of a hastepin with the contents of my .hyper.js file: .hyper.js
  • Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere): N/A

Issue

The config.summon.hideDock does not work as expected on Windows platform.

Steps to Reproduce

  1. Set the said option to true in the configuration file.
  2. Press the hotkey to summon hyper (e.g. Ctrl+;)
  3. Press again the hotkey to “hide” the hyper window.
  4. The hideDock has no effect on the window.

Expected Result

The hyper icon should be hidden from the taskbar (equivalent to dock in macOS).

Actual Result

The window is minimized instead of the window getting hidden.

Demonstration

hyper is minimized instead of being hidden

Shouldn't hyper hide the icon in taskbar when this option is enabled on Windows?

@dcalhoun
Copy link
Collaborator

Unfortunately, I believe hiding the dock is an ability Electron can only perform on macOS. I don’t think what you desire is possible.

If you research and find otherwise, let me know! I’d welcome a PR adding the functionality.

@DRSDavidSoft
Copy link
Author

@dcalhoun Thanks for the quick reply.

To overcome this limitation on Windows, Terminus puts the window into the traybar which effectively removes the icon from the taskbar.

This method (sample code) requires browser-window dependency.

Does this make sense, and can I do that in the PR?
It'll be cool to have a Hyper window in the background and summon it using the hotkey :)

@dcalhoun
Copy link
Collaborator

dcalhoun commented Nov 1, 2018

Oh, great! It does look like Electron provides an API for managing the Tray as well as a BrowserWindow API with similar hooks to your sample code.

I'm not too familiar with the Windows OS or the Tray (nor do I have access to a Windows machine for testing), so it'd be challenging for me to implement this feature. However, if you'd like to explore implementing this feature in a new PR, I support that.

Rather than adding the browser-window dependency, I'd prefer this feature be built with the API that Electron provides (i.e. the aforementioned Tray, BrowserWindow).

@dcalhoun dcalhoun reopened this Nov 1, 2018
@jcklpe
Copy link

jcklpe commented Nov 12, 2018

+💯 on this :)

Also out of curiosity but is it intended functionality that this hotkey cannot summon a hyper term unless it's already been manually opened and minimized?

@dcalhoun
Copy link
Collaborator

@jcklpe unless I'm mistaken, what you are describing is unrelated to this issue. Please open a new issue with detailed steps to reproduce and your expected outcome. Thanks.

@jcklpe
Copy link

jcklpe commented Nov 12, 2018

@dcalhoun Will do. I assumed from reading this stuff that it is impossible to access an electron app with a global hotkey though. Will log though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants