Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to import dlt signatures without a current SparkSession #6

Open
marijncv opened this issue Dec 7, 2022 · 3 comments
Open

Comments

@marijncv
Copy link

marijncv commented Dec 7, 2022

I've been happily using the dlt-with-debug library, but I'm running into an issue when importing the dlt signatures without an active SparkSession. I'm trying:

import dlt_with_debug.dlt_signatures as dlt

But the __init__.py calls the v2.py file which in turn tries to get the pipeline_id from the current SparkSession. But this fails when there is no active SparkSession.

I think my usecase can be achieved with an extra check in

pipeline_id = spark.conf.get("pipelines.id", None)
that first confirms there is an actual SparkSession before calling .conf.get() on it.

@souvik-databricks curious what you think! And I'd be happy to contribute via PR

@souvik-databricks
Copy link
Owner

Hi @marijncv Thank you for using the project and I saw your PR for the fix. Will review it and get it in by the end of this week.

@javamonkey79
Copy link

I am having the same issue, could you please merge the PR?

@javamonkey79
Copy link

@marijncv since @souvik-databricks is MIA, could you bumpversion in your fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants