Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BeautifulSoup Dependency #191

Open
chemeng opened this issue Jun 28, 2021 · 2 comments
Open

BeautifulSoup Dependency #191

chemeng opened this issue Jun 28, 2021 · 2 comments

Comments

@chemeng
Copy link

chemeng commented Jun 28, 2021

Why is beautifulsoup4 a dependency on the project? With some grepping I didn't see it being used anywhere.
@jkarstens
Copy link
Contributor

Looks like it's used in TestAuditAdmin, test_request_event_admin_no_users

django-easy-audit/easyaudit/tests/test_app/tests.py

Line 271 in 860a556

html = str(bs4.BeautifulSoup(content, features="html.parser").find(id="changelist-filter"))

Seems nothing is done with it though - looks like it wouldn't be too bad to remove the bs4 dependency from the test case

@mschoettle
Copy link
Contributor

This has been resolved in #267.

It's currently only available as a beta release but won't be present in the future anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chemeng @jkarstens @mschoettle