Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Fix background color / font color on fossos-website #199

Closed
SvenNekula opened this issue Apr 29, 2020 · 1 comment
Closed

Fix background color / font color on fossos-website #199

SvenNekula opened this issue Apr 29, 2020 · 1 comment
Assignees
Labels
bug class website help wanted html/css issue that involves some html/css skills

Comments

@SvenNekula
Copy link
Contributor

The background color and font color combination makes it unreadable (at least in chrome)
screenshot-fossos
.

@maxheld83 maxheld83 added class website graded-2 graded task, roughly worth 2 story points html/css issue that involves some html/css skills labels Apr 29, 2020
@maxheld83 maxheld83 reopened this Apr 30, 2020
@maxheld83 maxheld83 self-assigned this Apr 30, 2020
@maxheld83 maxheld83 added graded-4 graded task, roughly worth 4 story points help wanted and removed graded-2 graded task, roughly worth 2 story points graded-4 graded task, roughly worth 4 story points labels Apr 30, 2020
@maxheld83 maxheld83 added the bug label Apr 30, 2020
@maxheld83
Copy link
Member

The root cause of this was a bug in an upstream package: rich-iannone/DiagrammeR#375.

It's actually quite a convoluted bug and a couple of things made it hard to discover:

  1. The current CI takes the most recent package version available. In this case, that was the updated {DiagrammeR} which shipped with the faulty mermaid.css which had an overly aggressive css selector which set the opacity to 0.2, thereby rendering everything super hard to read. This problem should have been avoided (by @maxheld83) in the first place by freezing dependencies, and avoiding silent updates as per freeze deps #200 (just takes time).
  2. This, in turn, lead to every webpage which included a DiagrammeR plot to include the faulty CSS. Webpages (such as /linux) without DiagrammeR were unaffected, making this hard to debug.
  3. Making this harder to debug still, my local machine had apparently cached an older version of the CSS, which rendered the website perfectly on my local machine. (This is a common feature of browser to save on bandwidth -- you can avoid it by going into incognito mode).
    This lead me to the faulty conclusion that this was browser issue, though it was actually just faulty css.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug class website help wanted html/css issue that involves some html/css skills
Projects
None yet
Development

No branches or pull requests

2 participants