Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing ge, eq, ineq postprocessing implementations for TimeStampTZ #149

Open
Dustin-Ray opened this issue Sep 12, 2024 · 2 comments · May be fixed by #164
Open

missing ge, eq, ineq postprocessing implementations for TimeStampTZ #149

Dustin-Ray opened this issue Sep 12, 2024 · 2 comments · May be fixed by #164
Assignees
Labels
bug Something isn't working

Comments

@Dustin-Ray
Copy link
Contributor

Dustin-Ray commented Sep 12, 2024

Here:

todo!("Implement equality check for TimeStampTZ")

Here:

todo!("Implement inequality check for TimeStampTZ")

And Here:

todo!("Implement inequality check for TimeStampTZ")

@iajoiner I must have forgotten about these when we wrapped up timestamp, sorry about that. What are the above lines used for? Because right now, full provable inequality is supported on timestamp-related queries:

"SELECT * FROM table WHERE times > timestamp '1970-01-01T00:00:00Z';",
"SELECT * FROM table WHERE times < timestamp '1970-01-01T00:00:00Z';",
"SELECT * FROM table WHERE times >= timestamp '1970-01-01T00:00:00Z';",
"SELECT * FROM table WHERE times <= timestamp '1970-01-01T00:00:00Z';",
"SELECT * FROM table WHERE times = timestamp '1970-01-01T00:00:00Z';",

All succeed without incident. Should I fill out these missing implementations marked as todo!()?

@Dustin-Ray Dustin-Ray self-assigned this Sep 12, 2024
@iajoiner
Copy link
Contributor

iajoiner commented Sep 12, 2024

@drcapybara Yup! These should be filled out.

@JayWhite2357
Copy link
Contributor

If I'm not mistaken, these are only used in postprocessing, which is why those queries still work: they don't use postprocessing.
Regardless, these should be filled out.

@Dustin-Ray Dustin-Ray added the bug Something isn't working label Sep 17, 2024
@Dustin-Ray Dustin-Ray linked a pull request Sep 17, 2024 that will close this issue
16 tasks
@Dustin-Ray Dustin-Ray linked a pull request Sep 17, 2024 that will close this issue
16 tasks
@Dustin-Ray Dustin-Ray changed the title missing ge, eq, ineq implementations for TimeStampTZ missing ge, eq, ineq postprocessing implementations for TimeStampTZ Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants