Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for display_query_parameters in resource_dashboard #28

Open
ognnaot opened this issue Feb 26, 2018 · 4 comments
Open

Add support for display_query_parameters in resource_dashboard #28

ognnaot opened this issue Feb 26, 2018 · 4 comments

Comments

@ognnaot
Copy link

ognnaot commented Feb 26, 2018

Maybe it's just my use case, but I have display_query_parameters enabled on my dashboards. It's currently not supported so it always gets set to false upon terraform apply.

@nathmclean
Copy link
Collaborator

This will require some work to https://github.com/spaceapegames/go-wavefront as well as the provider. There are a fair few missing fields from go-wavefront and the provider compared to what is available in the API.

I'll put a ticket on our internal backlog to look at adding the additional fields, but I'm not sure when we'll get to it.

I've added some labels to this issue, maybe someone will pick it up and implement the changes before we get to it.

@ognnaot
Copy link
Author

ognnaot commented Feb 27, 2018

I added the parameter in my local fork. A few lines in go-wavefront/dashboard.go and resource_dashboard.go. LMK if I should submit a PR.
I'm sure there are many more missing options. I just happen to use display_query_parameters.

@nathmclean
Copy link
Collaborator

Feel free to submit a PR

@goldver
Copy link

goldver commented May 14, 2018

Hi guys, I have some issue,
do we have any expectation for merge fix of @ognnaot to master? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants