From 415304b8d7927e524a92e6f39ee1de9c8aa2b2a5 Mon Sep 17 00:00:00 2001
From: Campello Manuel <9112949+CampelloManuel@users.noreply.github.com>
Date: Fri, 9 Dec 2022 15:04:45 +0100
Subject: [PATCH] Update android_tests.yml

---
 .github/workflows/android_tests.yml | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/android_tests.yml b/.github/workflows/android_tests.yml
index c2d9d9125..15a605648 100644
--- a/.github/workflows/android_tests.yml
+++ b/.github/workflows/android_tests.yml
@@ -15,8 +15,7 @@ jobs:
     strategy:
       matrix:
         # test on emulators with these Android API versions. minSdk & higher
-        # TODO configurations that have NEVER completed a run: 31-google, 23-default
-        api-level: [ 23, 24, 28, 31, 32, 33 ]
+        api-level: [ 23, 25, 27, 29, 31, 33 ]
         target: [ default, google_apis ] # OS images without, or with, google apps
         exclude:  # the images for these configurations do not exist
           - api-level: 33
@@ -70,12 +69,15 @@ jobs:
         with:
           api-level: ${{ matrix.api-level }}
           target: ${{ matrix.target }}
-          profile: 5.4in FWVGA  # low resolution: faster. This device has no software buttons
+          profile: 5.4in FWVGA  # low resolution: faster. This has no software buttons
           arch: x86_64          # faster
           disk-size: 500M       # needed for saving org and json files
           force-avd-creation: false
-          # it's picky on the parameters
-          emulator-options: -no-boot-anim -no-window
+          # The emulator is picky on these parameters. For...
+          # tests with "-accel on": see github run #84
+          # tests with "-gpu host": the emulators never boot!
+          # tests with "-gpu off": see github run #87, faster & more stable
+          emulator-options: -no-boot-anim -no-window -gpu off
           disable-animations: true
           disable-spellchecker: true
           # starts the emulator, runs this script, then closes the emulator
@@ -108,11 +110,8 @@ jobs:
           force-avd-creation: false
           disable-animations: true
           disable-spellchecker: true
-          # TODO test -gpu host & then with -gpu off, compare timings
-          # tests with "-accel on": see github run #84
-          # tests with "-gpu host": the emulators never boot!
           emulator-options: -no-snapshot-save -verbose -no-boot-anim -no-window -gpu off
-          # runners also have powershell. maybe remake the script so it's more comprehensible ?
+          # runners also have powershell. maybe remake the script so it's comprehensible ?
           script: bash ./github_on_emu_started.sh
 
       - name: upload the generated files