-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change cell rendering #4
Comments
Leaflet-solr-heatmap is a Leaflet layer. Perhaps it could optionally hand off the rendering to another Leaftlet layer. Currently it supports the rendering types geojsonGrid and clusters. Clusters requires LeafletMarkerCluster. Along those lines, should we add a new type (heatmap?) that uses Leaflet.heat? |
While the above suggestions is workable, it is a bit of a hack. SolrHeatmap extends L.GeoJSON. The suggestion means that in "heatmap" mode, the SolrHeatmap layer wouldn't contain any features (like it does for geojson and cluster) but instead create and manage an instance of Leaflet.heat. Perhaps the Solr specific code should be refactored into a separate object that can be easily used with various kinds of layers? |
added initial support for type: heatmap creates an object of Leaflet.heat, which is a bit of a hack ideally, the solr code would be refactor into another class and support multiple renderers. colors are quite right due to bug in Leaflet.heat: http://stackoverflow.com/questions/26767722/leaflet-heat-issue-with-adding-points-with-intensity causes intermediate colors to be under represented
L.heat has a known issue with rendering intensity: Leaflet/Leaflet.heat#43. There's a modified version floating around that I used for the screenshot below. I will compare it to the L.heat code in github. |
With fix to Leaflet.Heat, bubble based heatmaps look good. |
Consider making individual heatmap cells circular and having them bleed/blend together like this site.
The text was updated successfully, but these errors were encountered: