Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate blocks that are contextually invalid #149

Closed
lrettig opened this issue Mar 9, 2021 · 3 comments
Closed

Invalidate blocks that are contextually invalid #149

lrettig opened this issue Mar 9, 2021 · 3 comments
Assignees

Comments

@lrettig
Copy link
Member

lrettig commented Mar 9, 2021

Blocks can become INVALID after some number of layers (see the pending change in spacemeshos/api#138). The explorer needs to be able to account for this. Blocks should be displayed with their status (which may be the same as layer status, i.e., PENDING, for some time), until they're finalized as VALID or INVALID. INVALID blocks should be marked invalid, or possibly dropped entirely, along with the transactions they contain.

@Motzart
Copy link
Contributor

Motzart commented Mar 26, 2021

Ok, @lrettig no problem, how you would like to see this? just add field status to block page or something else ?, maybe icon?

@lrettig
Copy link
Member Author

lrettig commented Mar 27, 2021

It's a little more complicated than this since it affects not only blocks, but also the transactions they contain.

CC @avive - thoughts?

@avive
Copy link
Contributor

avive commented Apr 17, 2021

Does the api support this? All of this data should come from the api: a block state (which may change at any time) + transaction state (via the receipt data eventually). Explorer backend should be able to handle this but I'm not sure what's the best design as any block or any transaction may change at any time. This whole discussion should move to API repo imo. This is all falls under support mesh reorg and self healing part of the api and explore backend...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants