From a4d36db1decde6e7735ac8a2ace7aade1d6217b5 Mon Sep 17 00:00:00 2001 From: Hatice Karatay Date: Fri, 15 Dec 2023 14:35:39 -0500 Subject: [PATCH 1/3] Add a tag "hide-cell" to developer notes metadata --- notebooks/ifu_optimal/ifu_optimal.ipynb | 56 ++++++++++++-- .../MOSspec_advanced.ipynb | 73 ++++++++++++++++--- 2 files changed, 114 insertions(+), 15 deletions(-) diff --git a/notebooks/ifu_optimal/ifu_optimal.ipynb b/notebooks/ifu_optimal/ifu_optimal.ipynb index 43cd1f63e..2b18345d2 100644 --- a/notebooks/ifu_optimal/ifu_optimal.ipynb +++ b/notebooks/ifu_optimal/ifu_optimal.ipynb @@ -2,7 +2,15 @@ "cells": [ { "cell_type": "markdown", - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [ + "hide-cell" + ] + }, "source": [ "# NIRSpec IFU Optimal Point Source Extraction" ] @@ -310,7 +318,15 @@ }, { "cell_type": "markdown", - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [ + "hide-cell" + ] + }, "source": [ "*Developer Note:* The units of the Cubeviz \"Sum\" collapse method (and all other spectra below) need to be multiplied by the pixel area in sr to yield flux units (MJy) instead of surface brightness units (MJy/sr)." ] @@ -385,7 +401,15 @@ }, { "cell_type": "markdown", - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [ + "hide-cell" + ] + }, "source": [ "*Developer Note:* Is there a way to retrieve the coordinates (RA, Dec) of the Subset1 region, for use in a SkyCircularAperture?" ] @@ -510,7 +534,13 @@ { "cell_type": "code", "execution_count": null, - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [] + }, "outputs": [], "source": [ "BoxPath = \"https://data.science.stsci.edu/redirect/JWST/jwst-data_analysis_tools/IFU_optimal_extraction/\"\n", @@ -538,7 +568,15 @@ }, { "cell_type": "markdown", - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [ + "hide-cell" + ] + }, "source": [ "*Developer Note:* The file Webbpsf_ifucube.fits is large (946.3 MB) and takes some time to load from Box.\n", "It might behoove the user to download it to a local directory and retrieve it from there." @@ -559,7 +597,13 @@ { "cell_type": "code", "execution_count": null, - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [] + }, "outputs": [], "source": [ "# Flip model PSF left-right to match data.\n", diff --git a/notebooks/mos_spectroscopy_advanced/MOSspec_advanced.ipynb b/notebooks/mos_spectroscopy_advanced/MOSspec_advanced.ipynb index eacfe8a06..196e9db0e 100644 --- a/notebooks/mos_spectroscopy_advanced/MOSspec_advanced.ipynb +++ b/notebooks/mos_spectroscopy_advanced/MOSspec_advanced.ipynb @@ -2,7 +2,13 @@ "cells": [ { "cell_type": "markdown", - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [] + }, "source": [ "# MOS Spectroscopy of Extragalactic Field\n", "\n", @@ -169,7 +175,15 @@ }, { "cell_type": "markdown", - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [ + "hide-cell" + ] + }, "source": [ "**Developer note**:
\n", "The download of JWST data could happen directly from MAST, but the observations are organized in separate folders, while Mosviz wants the data in a single folder. So we go with a box download." @@ -261,7 +275,15 @@ }, { "cell_type": "markdown", - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [ + "hide-cell" + ] + }, "source": [ "**Developer note**
\n", "Is there a way to get out an uncertainty array from the extraction?
\n", @@ -497,7 +519,15 @@ }, { "cell_type": "markdown", - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [ + "hide-cell" + ] + }, "source": [ "**Developer note**
\n", "The line list plugin cannot yet be accessed by the notebook. I can do it in the GUI though." @@ -873,7 +903,13 @@ { "cell_type": "code", "execution_count": null, - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [] + }, "outputs": [], "source": [ "plt.figure(figsize=[10, 6])\n", @@ -907,11 +943,30 @@ }, { "cell_type": "markdown", - "metadata": {}, + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [] + }, "source": [ "## Find the best-fitting template\n", - "It needs a list of templates and the redshift of the observed galaxy. For the templates, I am using a set of model SEDs generated with Bruzual & Charlot stellar population models, emission lines, and dust attenuation as described in Pacifici et al. (2012).\n", - "\n", + "It needs a list of templates and the redshift of the observed galaxy. For the templates, I am using a set of model SEDs generated with Bruzual & Charlot stellar population models, emission lines, and dust attenuation as described in Pacifici et al. (2012)." + ] + }, + { + "cell_type": "markdown", + "metadata": { + "editable": true, + "slideshow": { + "slide_type": "" + }, + "tags": [ + "hide-cell" + ] + }, + "source": [ "**Developer note**
\n", "Maybe there is a way to speed this up (maybe using astropy model_sets)? This fit is run with 100 models, but ideally, if we want to extract physical parameters from this, we would need at least 10,000 models. A dictionary structure with meaningful keys (which can be, e.g., tuples of the relevant physical parameters) could be better than a list? It could make later analysis much clearer than having to map from the list indices back to the relevant parameters." ] @@ -1069,7 +1124,7 @@ "name": "python", "nbconvert_exporter": "python", "pygments_lexer": "ipython3", - "version": "3.9.13" + "version": "3.11.6" } }, "nbformat": 4, From 77afe3a2f3975905dd365ed50c8b11091f01d736 Mon Sep 17 00:00:00 2001 From: Hatice Karatay Date: Fri, 15 Dec 2023 14:39:20 -0500 Subject: [PATCH 2/3] Update job execution to test PR --- .github/workflows/ci_runner.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci_runner.yml b/.github/workflows/ci_runner.yml index 8a30f9637..b5ef42c34 100644 --- a/.github/workflows/ci_runner.yml +++ b/.github/workflows/ci_runner.yml @@ -25,7 +25,7 @@ on: jobs: NotebookExecutionValidation: - uses: spacetelescope/notebook-ci-actions/.github/workflows/ci_runner.yml@v3 + uses: haticekaratay/notebook-ci-actions/.github/workflows/ci_runner.yml@hide-cell with: python-version: ${{ vars.PYTHON_VERSION }} permissions: From 8ceea5ef99339711167d69109726ec812ec2c632 Mon Sep 17 00:00:00 2001 From: Hatice Karatay <66814693+haticekaratay@users.noreply.github.com> Date: Fri, 15 Dec 2023 15:10:23 -0500 Subject: [PATCH 3/3] Revert execution reference ci_runner.yml --- .github/workflows/ci_runner.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci_runner.yml b/.github/workflows/ci_runner.yml index b5ef42c34..8a30f9637 100644 --- a/.github/workflows/ci_runner.yml +++ b/.github/workflows/ci_runner.yml @@ -25,7 +25,7 @@ on: jobs: NotebookExecutionValidation: - uses: haticekaratay/notebook-ci-actions/.github/workflows/ci_runner.yml@hide-cell + uses: spacetelescope/notebook-ci-actions/.github/workflows/ci_runner.yml@v3 with: python-version: ${{ vars.PYTHON_VERSION }} permissions: