update datamodels example to include more info #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eteq
requested review from
rosteen,
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
pllim
reviewed
Nov 11, 2024
pllim
reviewed
Nov 11, 2024
pllim
added
no-changelog-entry-needed
pllim
approved these changes
Nov 12, 2024
|
This is ready to merge but need admin override because of unrelated CI failure. Please squash merge. Thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3279 +/- ##
==========================================
- Coverage 88.76% 88.76% -0.01%
==========================================
Files 125 125
Lines 18956 18961 +5
==========================================
+ Hits 16826 16830 +4
- Misses 2130 2131 +1 ☔ View full report in Codecov by Sentry. |
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Nov 13, 2024
pllim
added a commit
that referenced
this pull request
Nov 13, 2024
…9-on-v4.0.x Backport PR #3279 on branch v4.0.x (update datamodels example to include more info)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on from #3252 that updates the docs to reflect a more complete version of creating and
NDDataobject from a jwst data model.The
dqand maybe theerrparts I think should be generic across jwst instruments, even though the exact interpretation is a bit variable (that is they should all be self-consistent, but different instruments I think use slightly conceptually different uncertainty models).